Skip to content

SCHOL-305: Implement new web reader designs#190

Merged
jackiequach merged 18 commits intomainfrom
SCHOL-305/implement-designs
Feb 18, 2026
Merged

SCHOL-305: Implement new web reader designs#190
jackiequach merged 18 commits intomainfrom
SCHOL-305/implement-designs

Conversation

@jackiequach
Copy link
Collaborator

@jackiequach jackiequach commented Jan 28, 2026

Figma

Description

  • Implements current page visible page number using page visibility and an intersection observer from this example.
  • Move page navigation from Footer to Header and removes Footer component.
  • Copies Tabs and Tooltip components from Reservoir (NYPL Design System). We are not installing the full design system to reduce bundle size.
  • Adds fit to width and height functionality.
  • Adds rotate functionality for PDF reader.
  • Adds toggleFullScreen prop to WebReader for consuming apps to handle sizing of parent components. See example
  • Updates Playwright test suite to run against localhost server instead of live Vercel site.

Screenshots

PDF reader header
image

EPUB reader header
image

Testing

Vercel preview "Fixed-height Embedded" for PDF and HTML readers

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web-reader Ready Ready Preview, Comment Feb 18, 2026 2:50pm

Request Review

@alea12
Copy link
Member

alea12 commented Feb 10, 2026

@jackiequach overall this looks good! Thank you for updating playwright test settings along the way.

One weird glitch I found... After rotation, the "next page" button does not work as expected.

Screen.Recording.2026-02-10.at.15.13.57.mov

* re-enable pdf tests and add test for page input

* fix flaky locator

* address comments
Copy link
Member

@alea12 alea12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jackiequach, I think this is ready to go!

@jackiequach jackiequach merged commit a81ba36 into main Feb 18, 2026
7 checks passed
@jackiequach jackiequach deleted the SCHOL-305/implement-designs branch February 18, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments