Call save_checkpoint_and_time() when saving checkpoint and compute elapsed duration for saving checkpoint before logging timer#4263
Queued
awsankur wants to merge 3 commits intoNVIDIA:mainfrom
Queued
Call save_checkpoint_and_time() when saving checkpoint and compute elapsed duration for saving checkpoint before logging timer#4263awsankur wants to merge 3 commits intoNVIDIA:mainfrom
awsankur wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
…apsed duration for saving checkpoint before logging timer Signed-off-by: Ankur Srivastava <your_verified_email@domain.com>
Member
|
/ok to test dc0c9e5 |
Member
|
/claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
asolergi-nv
approved these changes
Apr 16, 2026
Contributor
|
/ok to test f2e0b1d |
Phlip79
approved these changes
Apr 16, 2026
deepakn94
approved these changes
Apr 16, 2026
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24575928465 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24578774508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes an issue with OneLogger implementation in Megatron-LM, where for any pre-training or SFT job, time to save checkpoint is reported as 0 in Weights&Biases while number of checkpoints is reported correctly.
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.