CCM-11966: event schema string status #803
Conversation
| }, | ||
| { | ||
| "type": "object", | ||
| "properties": { |
There was a problem hiding this comment.
what does the event look like now if its deleted?
There was a problem hiding this comment.
or has it not changed, we're just no longer calling it out separately, since we're less concerned about the status?
There was a problem hiding this comment.
The different variants on EventData were only distinct in the statuses, when I changed all the statuses to string, there was no reason not to merge them.
Chris' work to allow nulls in template drafts is actually contradicting this though, since it applies to a distinctive TemplateDraftedEventData type.
Chris is preparing a new PR to resolve the conflict and combine the changes, and it will supercede this - I'm just leaving this open for now because my other PR depends on it.
Sorry I should have let everyone know review wasn't needed any more
3 participants
Description
template-management statuses typed as strings instead of enums, to allow us to modify these internal statuses without affecting schemas
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.