PPHA-528: Age when started smoking page #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Themitchell
requested changes
Jan 23, 2026
Contributor
Themitchell
left a comment
Themitchell
left a comment
There was a problem hiding this comment.
Looks good, couple of small comments on tags
lung_cancer_screening/questions/tests/unit/views/test_relatives_age_when_diagnosed.py
Outdated
Show resolved
Hide resolved
jamiefalcus
force-pushed
the
PPHA-528-age-when-started-smoking-page
branch
3 times, most recently
from
4e6c13e to
9ba2cd9
Compare
Themitchell
approved these changes
Jan 23, 2026
jamiefalcus
force-pushed
the
PPHA-528-age-when-started-smoking-page
branch
from
9ba2cd9 to
820bc2a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Adding the age when you started smoking page
Why are we making this change?
Allows users to say when they started smoking