Skip to content

VED-000: Update ECR repository reference in lambda.tf#1343

Open
Thomas-Boyle wants to merge 7 commits intomasterfrom
VED-000-terraform-apply-ecr-repodoesntexist-fix
Open

VED-000: Update ECR repository reference in lambda.tf#1343
Thomas-Boyle wants to merge 7 commits intomasterfrom
VED-000-terraform-apply-ecr-repodoesntexist-fix

Conversation

@Thomas-Boyle
Copy link
Copy Markdown
Contributor

Fixed a Terraform ordering issue for the operation Lambda ECR setup.

  • Updated infrastructure/instance/lambda.tf so module.docker_image.ecr_repo references aws_ecr_repository.operation_lambda_repository.name instead of a literal string. This creates an explicit dependency, ensuring the ECR repository exists before Terraform applies the lifecycle policy.

@github-actions
Copy link
Copy Markdown
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-000

avshetty1980
avshetty1980 previously approved these changes Mar 26, 2026
Copy link
Copy Markdown
Contributor

@avshetty1980 avshetty1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Akol125
Akol125 previously approved these changes Mar 26, 2026
…and add dependency on the repository. This change enhances clarity and ensures the Lambda module correctly references the ECR repository for image management.
…ribute instead of formatted string. This change improves clarity and ensures accurate dependency management for the Lambda module.
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@avshetty1980 avshetty1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This PR contains a fix for existing functionality. infrastructure Pull requests that update terraform code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants