Skip to content

Chore: [AEA-0000] - new workflow to update dev container#64

Merged
anthony-nhs merged 1 commit intomainfrom
workflow_to_update_devcontainer
Mar 25, 2026
Merged

Chore: [AEA-0000] - new workflow to update dev container#64
anthony-nhs merged 1 commit intomainfrom
workflow_to_update_devcontainer

Conversation

@anthony-nhs
Copy link
Copy Markdown
Collaborator

Summary

  • Routine Change

Details

  • new workflow to update dev container version

Copilot AI review requested due to automatic review settings March 25, 2026 16:07
@github-actions
Copy link
Copy Markdown
Contributor

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-0000

@anthony-nhs anthony-nhs merged commit d6f5659 into main Mar 25, 2026
5 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a scheduled/manual GitHub Actions workflow to automatically update the repository’s devcontainer version via a reusable workflow from NHSDigital/eps-common-workflows.

Changes:

  • Introduces a new workflow that runs on a weekly cron schedule and via workflow_dispatch.
  • Calls the shared update-dev-container-version.yml reusable workflow with base_branch: main and GitHub App credentials.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +18 to +19
AUTOMERGE_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
AUTOMERGE_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow passes GitHub secrets named CREATE_PULL_REQUEST_APP_ID / CREATE_PULL_REQUEST_PEM, but the other eps-common-workflows integrations in this repo use AUTOMERGE_APP_ID / AUTOMERGE_PEM. If these CREATE_PULL_REQUEST_* secrets aren’t configured in the repo settings, the workflow will fail at runtime; consider reusing the existing AUTOMERGE_* secrets (or rename the secrets being referenced) to stay consistent with the rest of the repo’s automation.

Suggested change
AUTOMERGE_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
AUTOMERGE_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}
AUTOMERGE_APP_ID: ${{ secrets.AUTOMERGE_APP_ID }}
AUTOMERGE_PEM: ${{ secrets.AUTOMERGE_PEM }}

Copilot uses AI. Check for mistakes.

jobs:
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other references to NHSDigital/eps-common-workflows in this repo are pinned to @5ac2707…, but this workflow pins update-dev-container-version.yml to a different SHA (@d2a4595…). Using multiple pins can make upgrades harder and lead to inconsistent behavior across workflows; consider aligning this pin with the repo’s existing eps-common-workflows SHA (or updating the other workflows in the same PR if a newer version is required).

Suggested change
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@5ac2707

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants