Chore: [AEA-0000] - new workflow to update dev container#64
Conversation
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
Adds a scheduled/manual GitHub Actions workflow to automatically update the repository’s devcontainer version via a reusable workflow from NHSDigital/eps-common-workflows.
Changes:
- Introduces a new workflow that runs on a weekly cron schedule and via
workflow_dispatch. - Calls the shared
update-dev-container-version.ymlreusable workflow withbase_branch: mainand GitHub App credentials.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| AUTOMERGE_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }} | ||
| AUTOMERGE_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }} |
There was a problem hiding this comment.
This workflow passes GitHub secrets named CREATE_PULL_REQUEST_APP_ID / CREATE_PULL_REQUEST_PEM, but the other eps-common-workflows integrations in this repo use AUTOMERGE_APP_ID / AUTOMERGE_PEM. If these CREATE_PULL_REQUEST_* secrets aren’t configured in the repo settings, the workflow will fail at runtime; consider reusing the existing AUTOMERGE_* secrets (or rename the secrets being referenced) to stay consistent with the rest of the repo’s automation.
| AUTOMERGE_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }} | |
| AUTOMERGE_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }} | |
| AUTOMERGE_APP_ID: ${{ secrets.AUTOMERGE_APP_ID }} | |
| AUTOMERGE_PEM: ${{ secrets.AUTOMERGE_PEM }} |
|
|
||
| jobs: | ||
| update_devcontainer_version: | ||
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333 |
There was a problem hiding this comment.
All other references to NHSDigital/eps-common-workflows in this repo are pinned to @5ac2707…, but this workflow pins update-dev-container-version.yml to a different SHA (@d2a4595…). Using multiple pins can make upgrades harder and lead to inconsistent behavior across workflows; consider aligning this pin with the repo’s existing eps-common-workflows SHA (or updating the other workflows in the same PR if a newer version is required).
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@d2a4595b1bfa59f04c7cecb080a126321d42a333 | |
| uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@5ac2707 |
Summary
Details