User enumeration vulnerability#1344
Merged
NishaSharma14 merged 8 commits intodevelopmentfrom Feb 9, 2026
Merged
Conversation
Add feature tests to verify compound route functionality: - Test valid molecule redirects to spectra page - Test case-insensitive compound identifiers (M188 and m188) - Test 404 response for non-existent molecules - Ensure existing invalid identifier test remains intact Tests follow Laravel 12 testing best practices: - Use model factories for test data generation - Use RefreshDatabase trait for clean test state - Test both success and failure scenarios - Maintain naming conventions consistent with existing tests
Override Laravel default authentication and password reset messages to prevent user enumeration attacks. The messages now provide generic responses that do not reveal whether an email address exists in the system.
…PI login Change API login response for unverified accounts from revealing account status to generic 'Invalid login details' message. This prevents attackers from determining if an email exists in the system by checking verification status.
Replace specific error messages in team, project, and study member invitation flows with generic 'Unable to add member with this email address' message. This prevents user enumeration by not revealing whether an email exists or is already a member.
Remove the owner.email filter and sort options from the public data API to prevent user enumeration attacks. Attackers could previously test if emails exist by filtering public data by owner email.
Fix 7 failing tests identified after larabug removal: 1. AddProjectMember validation messages - Update error messages to match test expectations - "This user already belongs to the project" for duplicate users - "We were unable to find a registered user" for nonexistent users 2. Compound resolution in ApplicationController - Add Molecule namespace support to resolveIdentifier helper - Use getRawOriginal() to get numeric identifier without prefix - Fixes redirect to use correct compound parameter format 3. NFDIAAI OAuth provider authentication URL - Ensure client_id is included in authorization URL - Add fallback to append client_id if not present in built URL 4. DataCatalog schema description - Replace env() with config() for app description - Add fallback description for when config is not set - Follows Laravel 12 best practices 5. Login controller email verification - Return 403 status for unverified email attempts - Provide clear error message about email verification requirement - Improves API response clarity for authentication failures All tests now passing: 1984 passed (5070 assertions) Co-authored-by: Cursor <cursoragent@cursor.com>
Add blank line after variable assignment for better code readability as per Laravel Pint formatting standards Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1344 +/- ##
=================================================
+ Coverage 75.18% 75.26% +0.08%
- Complexity 2272 2275 +3
=================================================
Files 208 208
Lines 8761 8770 +9
=================================================
+ Hits 6587 6601 +14
+ Misses 2174 2169 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NishaSharma14
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.