fix(main): remove dangling data_logger reference left over from pkl removal#13
Merged
Conversation
…emoval PR #10 (feat/hdf5-data-pipeline) removed the pkl writer import but missed two lines that still constructed a data_writer per episode. Every job crashes immediately at episode 0 with: NameError: name 'data_logger' is not defined The two lines were dead code — data_writer was constructed but never actually written to anywhere else in Main.py after the pkl removal. Surfaced by a smoke test of the new diagnostic logging stack on Stelaris main, which submits a real job through the dispatcher to RL-CT master. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #10 removed the `data_logger` import but missed two lines at `rl_code/Main.py:175-176` that still constructed a `data_writer` per episode. Every job crashes immediately at episode 0 with:
```
NameError: name 'data_logger' is not defined. Did you mean: 'exp_logger'?
```
Why this slipped through
The dead code was unreachable in tests (Main.py is the entry point, not directly tested). PR #10's tests covered the new `hdf5_writer` happy path but didn't end-to-end exercise Main.py against ARGoS. The bug was masked until today's smoke test of the new diagnostic logging stack on Stelaris main, which submits a real job through the dispatcher.
Fix
Delete the two lines. `data_writer` was constructed but never written to anywhere else in Main.py after the pkl removal, so the deletion has no behavioral side effect.
Test plan
🤖 Generated with Claude Code