feat: ship the omnibox refactor

drizzle/0001_tough_scream.sql

@@ -6,4 +6,4 @@ CREATE TABLE `pinned_tabs` (
 	`position` integer NOT NULL
 );
 --> statement-breakpoint
-CREATE INDEX `idx_pinned_tabs_profile_id` ON `pinned_tabs` (`profile_id`);
+CREATE INDEX `idx_pinned_tabs_profile_id` ON `pinned_tabs` (`profile_id`);

drizzle/0003_omnibox_shortcuts.sql

@@ -0,0 +1,13 @@
+CREATE TABLE IF NOT EXISTS `omnibox_shortcuts` (
+	`id` integer PRIMARY KEY AUTOINCREMENT NOT NULL,
+	`input_text` text NOT NULL,
+	`destination_url` text NOT NULL,
+	`destination_title` text DEFAULT '' NOT NULL,
+	`match_type` text NOT NULL,
+	`hit_count` integer DEFAULT 1 NOT NULL,
+	`last_access_time` integer NOT NULL
+);
+--> statement-breakpoint
+CREATE INDEX IF NOT EXISTS `idx_omnibox_shortcuts_input` ON `omnibox_shortcuts` (`input_text`);
+--> statement-breakpoint
+CREATE INDEX IF NOT EXISTS `idx_omnibox_shortcuts_destination` ON `omnibox_shortcuts` (`destination_url`);

drizzle/meta/_journal.json

@@ -22,6 +22,13 @@
       "when": 1772400000000,
       "tag": "0002_chromium_history",
       "breakpoints": true
+    },
+    {
+      "idx": 3,
+      "version": "6",
+      "when": 1774141367000,
+      "tag": "0003_omnibox_shortcuts",
+      "breakpoints": true
     }
   ]
 }

src/main/controllers/app-menu-controller/menu/items/file.ts

@@ -49,7 +49,7 @@ export const createFileMenu = (): MenuItemConstructorOptions => ({
           omnibox.hide();
         } else {
           omnibox.setBounds(null);
-          omnibox.loadInterface(null);
+          omnibox.sendShowEvent({ currentInput: null, openIn: "new_tab" });
           omnibox.show();
         }
       }

src/main/controllers/windows-controller/utils/browser/omnibox.ts

@@ -7,6 +7,12 @@ const omniboxes = new Map<BrowserWindow, Omnibox>();
 
 type QueryParams = { [key: string]: string };
 
+/** Parameters sent to the renderer when showing the omnibox. */
+interface OmniboxShowParams {
+  currentInput: string | null;
+  openIn: "current" | "new_tab";
+}
+
 export class Omnibox {
   public view: WebContentsView;
   public webContents: WebContents;
@@ -17,6 +23,13 @@ export class Omnibox {
 
   private isDestroyed: boolean = false;
 
+  /** Whether the initial load of the omnibox URL has completed. */
+  private initialLoadComplete: boolean = false;
+  /** Whether the renderer has registered its IPC listeners and can receive show events. */
+  private rendererReady: boolean = false;
+  /** Most recent show payload queued while waiting for renderer readiness. */
+  private pendingShowParams: OmniboxShowParams | null = null;
+
   constructor(parentWindow: BrowserWindow) {
     debugPrint("OMNIBOX", `Creating new omnibox for window ${parentWindow.id}`);
     const onmiboxView = new WebContentsView({
@@ -46,6 +59,18 @@ export class Omnibox {
       this.updateBounds();
     });
 
+    onmiboxWC.on("did-start-loading", () => {
+      this.rendererReady = false;
+    });
+
+    // Track when the initial load finishes
+    onmiboxWC.on("did-finish-load", () => {
+      if (!this.initialLoadComplete) {
+        this.initialLoadComplete = true;
+        debugPrint("OMNIBOX", "Initial load complete");
+      }
+    });
+
     setTimeout(() => {
       this.loadInterface(null);
       this.updateBounds();
@@ -65,9 +90,33 @@ export class Omnibox {
     }
   }
 
+  /**
+   * Load the omnibox interface URL. Only used for initial load.
+   * After the first load, the renderer stays alive and receives IPC messages.
+   */
   loadInterface(params: QueryParams | null) {
     this.assertNotDestroyed();
 
+    // If the omnibox renderer is already loaded, send params via IPC instead of reloading
+    if (this.initialLoadComplete) {
+      if (!this.rendererReady) {
+        debugPrint("OMNIBOX", "Renderer not ready yet, queueing show event until listener registration");
+        this.pendingShowParams = {
+          currentInput: params?.currentInput ?? null,
+          openIn: (params?.openIn as "current" | "new_tab") ?? "new_tab"
+        };
+        return;
+      }
+
+      debugPrint("OMNIBOX", "Omnibox already loaded, sending show event via IPC instead of reloading");
+      const showParams: OmniboxShowParams = {
+        currentInput: params?.currentInput ?? null,
+        openIn: (params?.openIn as "current" | "new_tab") ?? "new_tab"
+      };
+      this.webContents.send("omnibox:do-show", showParams);
+      return;
+    }
+
     debugPrint("OMNIBOX", `Loading interface with params: ${JSON.stringify(params)}`);
     const onmiboxWC = this.webContents;
 
@@ -88,6 +137,56 @@ export class Omnibox {
     }
   }
 
+  /**
+   * Send a show event to the already-loaded omnibox renderer via IPC.
+   * This is the preferred method after the initial load — no reload, no flicker.
+   */
+  sendShowEvent(params: OmniboxShowParams) {
+    this.assertNotDestroyed();
+
+    if (!this.initialLoadComplete) {
+      debugPrint("OMNIBOX", "Initial load not complete, routing show event through loadInterface");
+      const queryParams: QueryParams = { openIn: params.openIn };
+      if (params.currentInput !== null) {
+        queryParams.currentInput = params.currentInput;
+      }
+      this.loadInterface(queryParams);
+      return;
+    }
+
+    if (!this.rendererReady) {
+      debugPrint("OMNIBOX", "Renderer not ready yet, queueing show event");
+      this.pendingShowParams = params;
+      return;
+    }
+
+    debugPrint("OMNIBOX", `Sending show event with params: ${JSON.stringify(params)}`);
+    this.webContents.send("omnibox:do-show", params);
+  }
+
+  markRendererReady() {
+    this.assertNotDestroyed();
+    this.rendererReady = true;
+
+    if (!this.pendingShowParams) {
+      return;
+    }
+
+    const params = this.pendingShowParams;
+    this.pendingShowParams = null;
+    debugPrint("OMNIBOX", "Renderer ready, flushing queued show event");
+    this.webContents.send("omnibox:do-show", params);
+  }
+
+  /**
+   * Send a hide event to the renderer so it can reset its state.
+   */
+  sendHideEvent() {
+    this.assertNotDestroyed();
+    debugPrint("OMNIBOX", "Sending hide event to renderer");
+    this.webContents.send("omnibox:do-hide");
+  }
+
   updateBounds() {
     this.assertNotDestroyed();
 
@@ -140,7 +239,7 @@ export class Omnibox {
     this.assertNotDestroyed();
 
     debugPrint("OMNIBOX", "Showing omnibox");
-    // Hide omnibox if it is already visible
+    // Hide omnibox if it is already visible (safe: hide() no longer sends IPC)
     this.hide();
 
     // Show UI
@@ -182,6 +281,14 @@ export class Omnibox {
     debugPrint("OMNIBOX", "Hiding omnibox");
     this.view.setVisible(false);
 
+    // Do NOT send a hide IPC event here. The native view visibility
+    // (view.setVisible) is the sole mechanism for main-process hides.
+    // Sending hide IPC caused a race condition: blur events during show()
+    // would trigger maybeHide() → hide() → sendHideEvent(), undoing the
+    // prior sendShowEvent() and leaving the renderer with isVisible=false.
+    // The renderer handles its own state for user-initiated hides (Escape,
+    // match selection) and the show handler always resets state on next open.
+
     if (omniboxWasFocused) {
       // Focuses the parent window instead
       this.window.webContents.focus();

src/main/ipc/app/new-tab.ts

@@ -12,7 +12,7 @@ export function openNewTab(window: BrowserWindow) {
     if (omnibox.isVisible()) {
       omnibox.hide();
     } else {
-      omnibox.loadInterface(null);
+      omnibox.sendShowEvent({ currentInput: null, openIn: "new_tab" });
       omnibox.setBounds(null);
       omnibox.show();
     }

src/main/ipc/data/omnibox-shortcuts.ts

@@ -0,0 +1,37 @@
+import { ipcMain } from "electron";
+import { omniboxShortcutsService } from "@/saving/omnibox-shortcuts/shortcuts-service";
+
+// --- Omnibox Shortcuts IPC Handlers ---
+
+/**
+ * Search for shortcuts matching the given input text.
+ * Used by ShortcutsProvider in the renderer for omnibox suggestions.
+ */
+ipcMain.handle("omnibox-shortcuts:search", async (_event, inputText: string, limit?: number) => {
+  return omniboxShortcutsService.search(inputText, limit);
+});
+
+/**
+ * Record a shortcut when the user selects an omnibox suggestion.
+ * Fire-and-forget — called from the renderer when the user picks a result.
+ */
+ipcMain.on(
+  "omnibox-shortcuts:record-usage",
+  (_event, inputText: string, destinationUrl: string, destinationTitle: string, matchType: string) => {
+    omniboxShortcutsService.recordUsage(inputText, destinationUrl, destinationTitle, matchType);
+  }
+);
+
+/**
+ * Get all shortcuts for a specific destination URL.
+ */
+ipcMain.handle("omnibox-shortcuts:get-for-url", async (_event, destinationUrl: string) => {
+  return omniboxShortcutsService.getForUrl(destinationUrl);
+});
+
+/**
+ * Cleanup old shortcuts. Returns number of rows deleted.
+ */
+ipcMain.handle("omnibox-shortcuts:cleanup", async (_event, maxAgeDays?: number) => {
+  return omniboxShortcutsService.cleanup(maxAgeDays);
+});

src/main/ipc/index.ts

@@ -27,6 +27,9 @@ import "@/ipc/app/icons";
 import "@/ipc/app/open-external";
 import "@/ipc/app/onboarding";
 
+// Data APIs
+import "@/ipc/data/omnibox-shortcuts";
+
 // Special
 import "@/ipc/listeners-manager";
 import "@/ipc/webauthn";

src/main/ipc/window/omnibox.ts

@@ -20,7 +20,11 @@ ipcMain.on("omnibox:show", (event, bounds: Electron.Rectangle | null, params: {
 
   const omnibox = parentWindow.omnibox;
   omnibox.setBounds(bounds);
-  omnibox.loadInterface(params);
+  // Send params via IPC instead of reloading
+  omnibox.sendShowEvent({
+    currentInput: params?.currentInput ?? null,
+    openIn: (params?.openIn as "current" | "new_tab") ?? "new_tab"
+  });
   omnibox.show();
 });
 
@@ -40,3 +44,17 @@ ipcMain.on("omnibox:hide", (event) => {
   const omnibox = parentWindow.omnibox;
   omnibox.hide();
 });
+
+ipcMain.on("omnibox:renderer-ready", (event) => {
+  const omniboxWindow = browserWindowsManager
+    .getAll()
+    .find((window) => "omnibox" in window && window.omnibox.webContents === event.sender);
+
+  if (!omniboxWindow || !browserWindowsManager.isInstanceOf(omniboxWindow)) {
+    debugPrint("OMNIBOX", "Renderer-ready received for unknown omnibox webContents");
+    return;
+  }
+
+  debugPrint("OMNIBOX", "Renderer reported ready for IPC show events");
+  omniboxWindow.omnibox.markRendererReady();
+});

src/main/saving/db/schema.ts

@@ -123,3 +123,28 @@ export const historyVisits = sqliteTable(
 
 export type HistoryUrlRow = typeof historyUrls.$inferSelect;
 export type HistoryVisitRow = typeof historyVisits.$inferSelect;
+
+// --- Omnibox Shortcuts Table ---
+// Learned input-to-destination mappings (e.g., typing "gi" → github.com).
+// Separate from browsing history: this tracks what users select for specific
+// omnibox input, not every page visit.
+
+export const omniboxShortcuts = sqliteTable(
+  "omnibox_shortcuts",
+  {
+    id: integer("id").primaryKey({ autoIncrement: true }),
+    inputText: text("input_text").notNull(),
+    destinationUrl: text("destination_url").notNull(),
+    destinationTitle: text("destination_title").notNull().default(""),
+    matchType: text("match_type").notNull(),
+    hitCount: integer("hit_count").notNull().default(1),
+    lastAccessTime: integer("last_access_time").notNull()
+  },
+  (table) => [
+    index("idx_omnibox_shortcuts_input").on(table.inputText),
+    index("idx_omnibox_shortcuts_destination").on(table.destinationUrl)
+  ]
+);
+
+export type OmniboxShortcutRow = typeof omniboxShortcuts.$inferSelect;
+export type OmniboxShortcutInsert = typeof omniboxShortcuts.$inferInsert;

src/main/saving/history/browsing-history.ts

@@ -99,7 +99,7 @@ export function listBrowsingHistoryForProfile(profileId: string): BrowsingHistor
     .from(historyUrls)
     .where(eq(historyUrls.profileId, profileId))
     .orderBy(desc(historyUrls.lastVisitTime))
-    .limit(200)
+    .limit(2000)
     .all();
 
   return rows.map((row) => ({