Run the TrackQuality ANN directly from the onnx file with ONNX Runtime#4
Draft
AndrewEdmonds11 wants to merge 3 commits intoMu2e:mainfrom
Draft
Run the TrackQuality ANN directly from the onnx file with ONNX Runtime#4AndrewEdmonds11 wants to merge 3 commits intoMu2e:mainfrom
AndrewEdmonds11 wants to merge 3 commits intoMu2e:mainfrom
Conversation
Contributor
|
Took a look through this draft. Validation numbers match SOFIE to 4 decimals — behavior looks correct. A few structural items for when you come back to clean it up: Blockers
Bugs / risks
Nits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a draft of the code needed to run the TrkQual ANN directly from the onnx file. This will remove TMVA::SOFIE from the workflow. This is a draft while I work out final details and remove the old code. However, it is validated:
where
outputis the original output andORTis value with the new ONNXRuntime code