Open
Conversation
Yuki-Nagori
reviewed
Mar 30, 2026
| (tm-define (get-update-download-url) | ||
| (:secure #t) | ||
| (if (== (get-output-language) "chinese") | ||
| "https://liiistem.cn/install.html" |
Contributor
There was a problem hiding this comment.
这里应该使用mogan的链接
https://mogan.app/zh/
https://mogan.app/en/
MoonL79
reviewed
Mar 30, 2026
| (:secure #t) | ||
| (if (== (get-output-language) "chinese") | ||
| "https://liiistem.cn/install.html" | ||
| "https://liiistem.com/install.html")) |
Contributor
There was a problem hiding this comment.
总体评价：功能完整，实现清晰，文档详细。
主要问题：
1. version-update.scm - Debug 代码未移除
(display "Version update history cleared\n")
生产代码中不应有 display 调试输出，建议移除或改为日志函数。
2. qt_tm_widget.cpp - hasMock 布尔判断逻辑有问题
由于 MOCK-REMOTE-VERSION 始终是字符串而非 #f，所以 hasMock 永远为 true，这个条件没有意义。如果想支持 mockVersion 为 #f 时跳过 mock，应该改成：!is_bool (mockVersion)
3. C++ 内存管理
manager 在 lambda 中用 new 创建，虽然最后调用了 deleteLater()，但建议在 reply 的 finished 信号处理中直接 delete manager 更明确。
4. zh_CN.scm - 文件末尾缺换行符
其余代码质量良好，Scheme 部分右括号标记规范，注释清晰。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.