Compatibility Update for ForgeGradle 1.0

[zeng-github01]

Pull Request: Compatibility Update for ForgeGradle 1.0

Summary

This PR introduces critical compatibility updates for ForgeGradle 1.0. It primarily addresses the asset downloading failures caused by legacy Mojang service deprecation and upgrades the build system to a more stable Gradle version.

Changes

• Asset Download Fix:
  • Replaced the legacy asset downloading logic with the current Mojang API implementation.
  • This fix is backported and adapted from anatawa12/ForgeGradle-1.2.
• Gradle Wrapper Upgrade:
  • Updated Gradle from the legacy version to 4.10.
  • This improves build performance and enhances compatibility with Java 8 environments, which is essential for late-stage 1.6.4 development.
• Build Environment Adjustments:
  • Minor internal task adjustments to ensure compatibility with Gradle 4.10 APIs. (Rewrite by AI)

Reasoning

The original asset download servers used by ForgeGradle 1.0 are no longer functional, leading to "Download Failed" errors during workspace setup. By utilizing the updated Mojang API logic, the development environment for legacy Minecraft versions remains viable. Upgrading to Gradle 4.10 provides better support for modern IDEs and CI/CD pipelines.

Testing Performed

• Executed ./gradlew clean and successfully ran ./gradlew setupDevWorkspace.
• Verified that game assets (sounds, icons, etc.) are correctly downloaded to the local cache.
• Successfully compiled the project using Gradle 4.10.

[LexManos]

Updating the method to download assets is fine, however bumping the gradle version is a non-starter.

If you wish to help out with the effort to restore development for legacy versions, feel free to drop by the discord.
The current task I need done is to make the FernFlowerLegacy project buildable again.

[Jonathing]

If you want to contribute critical bug fixes to ForgeGradle 1.0, this is not the way to do it. And bumping the Gradle runtime version tells me that you still need to do more homework on why ForgeGradle is versioned the way it is, and how it has operated in the past. ForgeGradle 1.0 will never be supported in modern IDEs because the entire point of its continued existence is to allow legacy workspaces to function.

[zeng-github01]

The purpose of upgrading Gradle is to support building with the latest IntelliJ IDEA. There is no other purpose. @LexManos @Jonathing

If there's a better way to solve this problem, using this PR to fix Download Assets is fine.

Additionally, could you please upload a development kit for the last Forge release, 1.6.4? Maven doesn't have userdev, I don't know how to build it. Thank you.

[LexManos]

As I said, updating the gradle version is a non-starter.
If you want to help get legacy versions working on modern toolchains you can work on legacy fernflower.

I am open to a PR to fix the asset downloading, but bumping the gradle version is not viable for how FG works.

[zeng-github01]

As I said, updating the gradle version is a non-starter.
If you want to help get legacy versions working on modern toolchains you can work on legacy fernflower.

I am open to a PR to fix the asset downloading, but bumping the gradle version is not viable for how FG works.

Understood. Could you please upload the userdev jar for versions 1.6.4 - 9.11.1.1345? Currently, the fixed FG1.0 only supports versions 1.6.4 - 9.11.1.964 because the former lacks a userdev build.

[LexManos]

No, its not possible. 1.6.4-9.11.1.1345 is not gradle compatible

[zeng-github01]

No, its not possible. 1.6.4-9.11.1.1345 is not gradle compatible

Alright, I know