Skip to content

Fix view bobbing affecting StorageESP while using shaders #6167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noramibu wants to merge 1 commit into from
Closed

Fix view bobbing affecting StorageESP while using shaders #6167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/main/java/meteordevelopment/meteorclient/mixin/GameRendererMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,10 @@ private void onRenderWorld(RenderTickCounter tickCounter, CallbackInfo ci, @Loca

Profilers.get().push(MeteorClient.MOD_ID + "_render");

// Create renderer and event
// Create renderers

if (renderer == null) renderer = new Renderer3D(MeteorRenderPipelines.WORLD_COLORED_LINES, MeteorRenderPipelines.WORLD_COLORED);
if (depthRenderer == null) depthRenderer = new Renderer3D(MeteorRenderPipelines.WORLD_COLORED_LINES_DEPTH, MeteorRenderPipelines.WORLD_COLORED_DEPTH);
Render3DEvent event = Render3DEvent.get(matrixStack, renderer, depthRenderer, tickDelta, camera.getCameraPos().x, camera.getCameraPos().y, camera.getCameraPos().z);

// Update model view matrix

Expand All @@ -133,21 +132,23 @@ private void onRenderWorld(RenderTickCounter tickCounter, CallbackInfo ci, @Loca

Matrix4f inverseBob = new Matrix4f(matrices.peek().getPositionMatrix()).invert();
RenderSystem.getModelViewStack().mul(inverseBob);
matrices.pop();

// Call utility classes (apply bob correction when Iris shaders are active)

Matrix4f correctedPosition = MixinPlugin.isIrisPresent && RenderUtils.isShaderPackInUse() ? new Matrix4f(position).mul(inverseBob) : position;
RenderUtils.updateScreenCenter(projection, correctedPosition);
NametagUtils.onRender(position);

// Render
// use our matrices with bob transform, not vanilla's matrixStack which is identity when Iris is active
Render3DEvent event = Render3DEvent.get(matrices, renderer, depthRenderer, tickDelta, camera.getCameraPos().x, camera.getCameraPos().y, camera.getCameraPos().z);

renderer.begin();
depthRenderer.begin();
MeteorClient.EVENT_BUS.post(event);
renderer.render(matrixStack);
depthRenderer.render(matrixStack);
renderer.render(matrices);
depthRenderer.render(matrices);

matrices.pop();

// Revert model view matrix

Expand Down