chore: Bump messenger and controller dependencies#3930
Merged
FrederikBolding merged 4 commits intomainfrom Mar 27, 2026
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3930 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 426 426
Lines 12316 12316
Branches 1935 1935
=======================================
Hits 12139 12139
Misses 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for Dependabot PRs as more than one dependency needed to be bumped to get passing CI.
Bumps
messenger,base-controller,storage-service,permission-controller&approval-controller.Note
Medium Risk
Upgrades
@metamask/messengerto1.0.0and bumps several core controller dependencies, which can subtly affect controller messaging/type contracts across Snaps runtime components. Code changes are mostly type-level, but they touch central controllers (SnapController, routing, UI) so integration/CI coverage is important.Overview
Updates Snaps packages to newer controller/messenger releases (notably
@metamask/messenger@1.0.0, plusapproval-controller,base-controller,permission-controller@12.3.0, andstorage-service).Refactors Snaps controllers to match updated
permission-controlleraction typings by replacing legacy types (e.g.,GetPermissions,HasPermission,UpdateCaveat) with the newPermissionController*Actiontype exports inSnapController,CronjobController,SnapInsightsController,SnapInterfaceController, andMultichainRoutingService.Adjusts the simulation setup to align with the updated
permission-controllergenerics by simplifyingPermissionControllertyping and pruning now-unneeded constraint type imports, and updatesyarn.lockaccordingly.Written by Cursor Bugbot for commit 24da3f4. This will update automatically on new commits. Configure here.