feat: use @metamask/messenger/generate-action-types CLI#575
Draft
cryptodev-2s wants to merge 5 commits intomainfrom
Draft
feat: use @metamask/messenger/generate-action-types CLI#575cryptodev-2s wants to merge 5 commits intomainfrom
cryptodev-2s wants to merge 5 commits intomainfrom
Conversation
Replace local copy-pasted script with the CLI from @metamask/messenger. Uses preview build until release.
4 tasks
cryptodev-2s
force-pushed
the
feat/use-messenger-generate-action-types
branch
from
ab9384b to
3166d8d
Compare
cryptodev-2s
force-pushed
the
feat/use-messenger-generate-action-types
branch
from
3166d8d to
9626783
Compare
Use resolutions to override @metamask/messenger and @metamask/base-controller with preview builds. This ensures consistent types across all transitive dependencies and fixes the build.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cryptodev-2s
force-pushed
the
feat/use-messenger-generate-action-types
branch
from
5555741 to
7e4a4c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace the local copy-pasted
scripts/generate-method-action-types.ts(759 lines) with the CLI from@metamask/messenger/generate-action-types.Currently uses a preview build (
@metamask-previews/messenger@0.3.0-preview-f11c28cc2) via npm alias. Once MetaMask/core#8264 is merged and released, the dependency should be updated to the released version.References
generate-action-typesCLI tool as subpath export core#8264