refactor: remove outdated cursor rules and streamline documentation#1724
Open
drqsatoshi wants to merge 14 commits intoMetaMask:mh/add-cli-to-update-tokensfrom
Open
refactor: remove outdated cursor rules and streamline documentation#1724drqsatoshi wants to merge 14 commits intoMetaMask:mh/add-cli-to-update-tokensfrom
drqsatoshi wants to merge 14 commits intoMetaMask:mh/add-cli-to-update-tokensfrom
Conversation
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: gabrieledm <gabriele.delmonte@proton.me>
Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Nick Gambino <gambinish@users.noreply.github.com>
drqsatoshi
changed the base branch from
master
to
mh/add-cli-to-update-tokens
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
cli-update-asset.js
Outdated
| } else if (!metadata.logo) { | ||
| // Default logo path even if no logo provided yet | ||
| metadata.logo = `./icons/${chain}/${asset}.svg`; | ||
| } |
There was a problem hiding this comment.
Update writes metadata with missing icon file
Medium Severity
When update runs without --logo, it assigns a default metadata.logo path even if no icon exists. commandUpdate then reports success while creating metadata that immediately fails verify due to a missing file, producing inconsistent CLI behavior.
| @@ -0,0 +1,11 @@ | |||
| <svg width="800" height="800" viewBox="0 0 800 800" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
Non-checksummed EVM address in icon path
Medium Severity
The new icon uses a lowercase EVM address in its CAIP-19 filename, not an EIP-55 checksummed form. If asset lookup and metadata follow checksummed identifiers, this icons/... entry won’t match the canonical asset key and can fail to resolve at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it deletes the
cli-update-asset.jstooling used to create/verify metadata and may break developer workflows or tests that expect it, though runtime code is otherwise largely unaffected.Overview
Removes the asset-management CLI and redundant AI pointer docs, leaving
.cursorrules,CLAUDE.md, andcli-update-asset.jsempty and consolidating the remaining guidance in.github/copilot-instructions.mdwith an expanded quick reference.Adds several new token icons (e.g., under
icons/eip155:1329andicons/eip155:4326) as new SVG files.Written by Cursor Bugbot for commit 50d5883. This will update automatically on new commits. Configure here.