Conversation
Co-authored-by: Nick Gambino <gambinish@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| { | ||
| "name": "Copper", | ||
| "symbol": "xyz:COPPER", | ||
| "decimals": 6, |
There was a problem hiding this comment.
Inconsistent decimals field absent from all other metadata files
Medium Severity
The "decimals": 6 field is present in the COPPER metadata but absent from every other metadata file in the metadata/ directory, including the Gold and Silver hip3 assets this PR claims to follow as a design pattern. The decimals field only exists in contract-map.json, never in individual metadata JSON files. This inconsistency could cause unexpected behavior in consuming code that doesn't expect this field, or the value may simply be ignored, making it misleading dead metadata.
blurpesec
requested changes
Feb 11, 2026
Contributor
blurpesec
left a comment
blurpesec
left a comment
There was a problem hiding this comment.
A couple of things:
- This is an invalid caip-19 ID. it might cause issues in some of our parsing functions somewhere in our token metadata stack. Or it'll just be excluded when we pull this in via etl functions.
- Does this have a contract address associated with it? Is there a way to view it on https://hyperevmscan.io/ ?
blurpesec
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add COPPER hip3 asset metadata and a generated SVG icon.
The user requested adding a COPPER hip3 asset and mentioned attaching an SVG. As the attached file was not accessible to the cloud agent, a new SVG icon was generated following the design pattern of existing metal hip3 assets (Gold, Silver) with a copper color.
Note
Low Risk
Static asset/metadata additions only; no runtime logic changes, with primary risk limited to incorrect token metadata or logo path.
Overview
Adds a new HIP-3 asset entry for Copper (
xyz:COPPER) oneip155:999, including metadata (decimals: 6) and a logo reference.Introduces a new generated SVG icon at
icons/eip155:999/hip3:xyz_COPPER.svgusing a copper color scheme consistent with existing metal assets.Written by Cursor Bugbot for commit b80273f. This will update automatically on new commits. Configure here.