Umdp3 checker in python #153
Open
+3,846
−3,476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
investigations as to whether it's worked and how it can be improved.
and is to std out whereas the origianl wrote to std err. It's not clear if the Python version terminated after the first file with errors, or genuinely didn't spot the errors in the other files. Branch used to look for errors is : https://code.metoffice.gov.uk/svn/um/main/branches/dev/roddysharp/vn13.9_deliberate_umdp3_failures
… all the edited files.
… in trunk mode...
…p3_checkas I think Perl did it for both cases..
…or a Trunk in suite..
methodology. Plus making the branch processing of files changes return a list.
…clarity and to reduce the size of umdp3.py.
hints as at every step it suggests something else...
yaswant
reviewed
Jan 20, 2026
Collaborator
yaswant
left a comment
yaswant
left a comment
There was a problem hiding this comment.
Few minor cosmetic change suggestions for clarity and around docstring rules (https://peps.python.org/pep-0257/) for your consideration.
We'll aim to use consistent Copyright statements according to the guidelines in https://github.com/MetOffice/Momentum/blob/main/docs/COPYRIGHT_TEMPLATE.
yaswant
reviewed
Jan 20, 2026
Collaborator
yaswant
left a comment
yaswant
left a comment
There was a problem hiding this comment.
...and few missed in last review.
Collaborator
|
over to you @r-sharp |
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
yaswant
approved these changes
Jan 20, 2026
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sci/Tech Reviewer: @jennyhickson
Code Reviewer: @yaswant
Description
Summary
Replacing the old Perl umdp3 compliance checking script with a half baked Python one.
Changes
Remove all old Perl files.
Add Python translations after some heavy refactoring.
This provides a framework, and some very simple tests to run on Fortran code.
It will need some tweaking as we stumble over the defficiencies we see when used in anger.
Impact
Replaces a set of Perl scripts which was hardwired to FCM to a Python version capable of using git_bdiff
Issues addressed
Resolves
One of the last remaining Perl script uses in the toolset
Hardwiring of our style checker to FCM
Checklist