Open
Conversation
Pull Request Test Coverage Report for Build 23546478774Details
💛 - Coveralls |
MarcelGeo
requested changes
Mar 31, 2026
Collaborator
MarcelGeo
left a comment
There was a problem hiding this comment.
Should we make this as standard migration step? Like remove branch in alembic?
Collaborator
Author
Unfortunately it cannot be done via alembic if migration file is already gone. And unstamp if file is still present leads to missing upgrade to that head we want to get rid of (it is like catch 22). So best to patch DB manually and have it in migration guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branching point in community line from few years ago only creates confusion and make upgrades more difficult. Let's remove the old migration, which cleans
headsandhistoryalembic commands.Deployment note
Because existing deployments might have stamped version where file physically do not exist it would break alembic commands, e.g.
flask db currentwill not work. We can't therefore usestamp --purgeand we need to remove the row using sqlOnce it is gone,
flask dbcommands work as expected.