Skip to content

Refactor filtering demo#4430

Merged
Withalion merged 13 commits intodev/filteringfrom
refactor/filtering-demo
Mar 31, 2026
Merged

Refactor filtering demo#4430
Withalion merged 13 commits intodev/filteringfrom
refactor/filtering-demo

Conversation

@Withalion
Copy link
Copy Markdown
Contributor

resolves #4412

PR merges current master and refactors some stuff that I noticed.

@github-actions
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23709677750

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 158 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 57.986%

Files with Coverage Reduction New Missed Lines %
mm/app/filtercontroller.h 2 20.0%
mm/core/merginapi.cpp 7 75.3%
mm/app/activeproject.cpp 51 70.63%
mm/app/main.cpp 98 36.02%
Totals Coverage Status
Change from base Build 23430504555: 0.1%
Covered Lines: 8800
Relevant Lines: 15176

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 65881 dmg Expires: 27/06/2026 #6588
linux Build 📬 Mergin Maps 65991 x86_64 Expires: 27/06/2026 #6599
win64 Build 📬 Mergin Maps 57831 win64 Expires: 27/06/2026 #5783
Android Build 📬 Mergin Maps 790051 APK [arm64-v8a] Expires: 27/06/2026 #7900
📬 Mergin Maps 790051 APK [arm64-v8a] Google Play Store #7900
Android Build 📬 Mergin Maps 790011 APK [armeabi-v7a] Expires: 27/06/2026 #7900
📬 Mergin Maps 790011 APK [armeabi-v7a] Google Play Store #7900
iOS Build 📬 Build number: 26.03.883911 #8839

@Withalion Withalion linked an issue Mar 30, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@gabriel-bolbotina gabriel-bolbotina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.
Just a line to be formatted

Co-authored-by: Gabriel Bolbotina <80618569+gabriel-bolbotina@users.noreply.github.com>
@Withalion Withalion merged commit cd676e1 into dev/filtering Mar 31, 2026
12 checks passed
@Withalion Withalion deleted the refactor/filtering-demo branch March 31, 2026 11:55
gabriel-bolbotina added a commit that referenced this pull request Mar 31, 2026
gabriel-bolbotina added a commit that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review filtering claude code

4 participants