Open
Conversation
Pull Request Test Coverage Report for Build 23840373656Details
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
reviewed
Mar 31, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Regarding the questions:
- keep the sizes as they are
- see the comment below, is it enough?
Comment on lines
+870
to
+872
| onClicked: { | ||
| root.openFiltersPanel() | ||
| } |
Contributor
There was a problem hiding this comment.
we could either add double click listener here (and also into MMMapButton) or clickAndHold listener which would just temporarily disable the filters (feel free to call here just some method on just reverse filterController like pauseActiveFilters we'll add it laterfiltersEnabled property on filterController)
Contributor
Author
There was a problem hiding this comment.
I think we should also fire a notification "All filters have been temporarily disabled. Press twice/ and hold to re-enable them". What do you think?
gabriel-bolbotina
force-pushed
the
filter-floating-chip
branch
from
7f9a538 to
1222dc3
Compare
📦 Build Artifacts Ready
|
Deleted filled filter icon Updated visuals for the chip Changed the chip position Formatted code
Updated the chip visuals
Updated the filter svg to be 24 x 24
gabriel-bolbotina
force-pushed
the
filter-floating-chip
branch
from
1222dc3 to
26f3e9d
Compare
📦 Build Artifacts Ready
|
Added click and hold Added draft filtersEnabled variable in filter controller
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the following:
Updated visual demo:
filter-chip-update.mov