Open
Conversation
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Withalion
added
FROZEN 🥶
📦 Build Artifacts Ready
|
Contributor
|
Some visual and component changes:
|
This commit adds both UDP & TCP sockets under one network provider. We further differ external provider into bluetooth and network providers.
Modified the MMIconCheckBoxHorizontal to feature a description if needed Modularised the MMPositionProviderPage Refactored MMBluetoothConnectionDrawer to be used for the network provider as well Changes the connecting and failure images for the network provider Other small changes
gabriel-bolbotina
force-pushed
the
feature/network-provider
branch
from
c0e811a to
c415f60
Compare
Pull Request Test Coverage Report for Build 23595311521Details
💛 - Coveralls |
📦 Build Artifacts Ready
|
Added ip address getter for network provider Changed provider constructor to make iOS device connect to external IP provider
📦 Build Artifacts Ready
|
Added hyperlink Modified the getIPAddress method Enhanced visuals
📦 Build Artifacts Ready
|
|
GPS Outstanding Issues & Recommnedations: iOS / Android:
2. External receiver connection details — IP address and port not displayed
3. External receiver settings — no option to edit after initial setup
iOS only 4. Manage GPS Receiver" button is cut off and inaccessible
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1893
This PR adds new network position provider support. The user is able to connect both UDP and TCP providers.
New UI:
These designs are not final, new design here: https://www.figma.com/design/d78a4ehBBgK6MyxCTuCAqg/Mobile-App?node-id=5837-12631
TODO:
MMIconCheckBoxHorizontalis the component we want to reuse and update to new designMMPositionProviderPage