fix(ci): match engine's merge queue PR title prefix#975
Conversation
The engine generates MQ draft PR titles as "merge queue: ..." (with a space) but the detector checked for "merge-queue: " (with a hyphen), so the merge queue base SHA override never fired. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: Id5cf5a1187dddaa17f4a9c839db833a15444557d
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
🧪 CI InsightsHere's what we observed from your CI run for 7abf1b3. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the merge queue base SHA detection logic. The code was checking for PR titles starting with "merge-queue: " (with a hyphen), but the Mergify engine actually generates merge queue draft PR titles with "merge queue: " (with a space). This mismatch prevented the merge queue base SHA override from triggering.
Changes:
- Updated the title prefix check in
detector.pyfrom "merge-queue: " to "merge queue: " - Updated the test case to use a more realistic merge queue title format that matches the actual engine output
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mergify_cli/ci/git_refs/detector.py | Fixed the title prefix check from "merge-queue: " to "merge queue: " to match engine output |
| mergify_cli/tests/ci/git_refs/test_git_refs_detector.py | Updated test to use correct prefix and more realistic merge queue PR title |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge Queue StatusRule:
This pull request spent 40 seconds in the queue, including 6 seconds running CI. Required conditions to merge
|
The engine generates MQ draft PR titles as "merge queue: ..." (with a
space) but the detector checked for "merge-queue: " (with a hyphen),
so the merge queue base SHA override never fired.
Fixes MRGFY-6270
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com