Open
Conversation
Move MarkBind onto Bootstrap 5.3.8 and the matching Bootswatch release so the site can use Bootstrap's native theme switching instead of custom one-off overrides. This establishes the asset baseline needed for runtime dark mode without changing page behavior yet.
Update the checked-in functional expectations after the Bootstrap upgrade and theme-aware page rendering changes. This records the new generated HTML and bundled assets so future CLI regressions are measured against the dark-mode-capable output.
Teach page generation to load both light and dark highlight themes, set the Bootstrap theme before styles paint, and apply dark-safe defaults to built-in templates. This keeps the initial render in sync with the chosen theme and avoids flashes of mismatched UI.
darkmode is set to be opt in for now until mature However, if user's device is on dark mode, bootstrap will default to dark mode until javascript loads, then switch it to white mode
Handle disabling dark mode in page.njk. this avoids the stutter in the nav bar when the javascript loads
Use existing highlight color instead of --bs-hightlight-bg which affects readability.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2889 +/- ##
=======================================
Coverage 71.35% 71.35%
=======================================
Files 133 133
Lines 7229 7229
Branches 1611 1603 -8
=======================================
Hits 5158 5158
+ Misses 2065 1970 -95
- Partials 6 101 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Add user facing AI skills to MarkBind. This could help users with incorporating
AI workflows into their MarkBind site generation. This includes formatting the
content in appropriate markbind components and tweaking site settings.
Anything you'd like to highlight/discuss:
This is a preview of the skills. DO NOT merge it into this repository. The
skills are meant to live on its repository within this organization. A new
command
markbind skillswill be added to the CLI to allow users to downloadthe skills. The skills will be version controlled against the MarkBind version
to ensure consistency between the skills and MarkBind features.
Testing instructions:
Manually place the skills in your MarkBind project of your coding tool's
recognizable path. run a few prompts to test out the skills.
Proposed commit message: (wrap lines at 72 characters)
DO NOT MERGE ME
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):