MDEV-28374 UBSAN signed integer overflow PROCEDURE ANALYSE#5038
Merged
Conversation
grooverdan
added
the
MariaDB Foundation
grooverdan
force-pushed
the
MDEV-28374
branch
3 times, most recently
from
5bc7f18 to
8dc6453
Compare
grooverdan
changed the title
PROCEDURE ANALYSE returns a Std (Standard deviation) which involves the sum of squares, which can exceed the longlong datatypes. Adjust the sum_sqr and sum value to double to acocunt that its only used in a double context and precision isn't required. Reviewed by: Alexander Barkov
abarkov
approved these changes
May 12, 2026
Contributor
abarkov
left a comment
abarkov
left a comment
There was a problem hiding this comment.
The patch is OK to push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROCEDURE ANALYSE returns a Std (Standard deviation) which involves the sum of squares, which can exceed the longlong datatypes.
Emit a ER_DATA_OVERFLOW warning when encountering types that overflow the values for the Std output.
Adjust the sum_sqr value to double to acocunt that its only used in a double context and precision isn't required.