MDEV-34210 Improve auto-inc upgrade check message #4602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 0381921, logic was added to fix bogus values of PAGE_ROOT_AUTO_INC when upgrading from MySQL or versions of MariaDB < 10.2.10. As part of this change, if a table's frm version was less than 10.2.10 and the server was in a read-only state (preventing the frm version from being updated), a message was introduced during the execution of CHECK TABLE FOR UPGRADE informing users that the auto_increment check would be performed on each open of the table. However, this message didn't mention the fact that the server being in a read-only state would prevent the frm version from being updated thus causing confusion as the message would not go away even after running CHECK TABLE FOR UPGRADE. The message is now improved for clarity. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
A small simplification is made to ha_innobase::check() by removing redundant checks for `check_for_upgrade()` and handler_flags. ha_innobase::handler_flags is only set by `check_for_upgrade()`. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
Contributor
Author
|
Test failure on Windows ARM64 seems unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements to clarity for auto increment checks during
CHECK TABLE FOR UPGRADEoperations. The message now makes it clear that aCHECK TABLE FOR UPGRADEmust be run while the engine is not in a read-only state for the auto increment check on each open notification to be cleared.Release Notes
N/A
How can this PR be tested?
Existing
innodb.autoinc_importMTR had been updated according to the new notification message.PR quality check
Copyright
All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.