Skip to content
/ server Public

Redundant copy cleanup (NFC) #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
sfu2 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Redundant copy cleanup (NFC) #4587

sfu2 wants to merge 3 commits into from
+11 −14

Conversation

@sfu2
Copy link

@sfu2 sfu2 commented Jan 23, 2026

This PR fixes a few unnecessary copies related to containers.

  1. replace push_back with emplace_back to avoid a temporary copy of Datafile
  2. iterate unordered map with reference to avoid implicit container copy
  3. rewrite tpool::circular_queue::resize to resize the vector in place
    If m_head > m_tail, resize and update m_capacity. Else, shift elements after m_tail to the end of the vector.

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sfu2 @CLAassistant