refactor(shield)!: createRule mirrors rule signature; doc + 3.0.0-beta.7#143
Merged
refactor(shield)!: createRule mirrors rule signature; doc + 3.0.0-beta.7#143
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
BREAKING CHANGE: createRule is now curried as createRule(name?, options?)(fn),
matching graphql-shield's rule(). The previous (fn, cache?) form and the
implicit 'strict' cache default are removed — pass { cache: 'strict' }
explicitly if needed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createRulenow mirrors graphql-shield'srule()— curriedcreateRule(name?, options?)(fn)instead ofcreateRule(fn, cache?). The implicit'strict'cache default is removed; pass{ cache: 'strict' }explicitly if needed.parent,args,ctx(and addsinfo: GraphQLResolveInfo) on the innerfnvia generics; return type now matches shield'sboolean | string | Error.BaseRequestInfoinsrc/request-info.ts, clarifying thaturlis a path + query string (combine withbaseUrlfor the absolute URL).createRulesection updated for the new signature.3.0.0-beta.6→3.0.0-beta.7.Migration
Test plan
🤖 Generated with Claude Code