Open
Conversation
Nihisil
force-pushed
the
add-hand-config-doc
branch
from
e5d7b04 to
d4be7c8
Compare
Apricot-S
requested changes
Mar 5, 2026
| :attr:`HandConstants.KAZOE_LIMITED`, :attr:`HandConstants.KAZOE_SANBAIMAN`, | ||
| or :attr:`HandConstants.KAZOE_NO_LIMIT` | ||
| :vartype kazoe_limit: int | ||
| :ivar kiriage: round up to mangan when han/fu are at the boundary (e.g. 4 han 30 fu) |
Collaborator
There was a problem hiding this comment.
Since the only targets for kiriage mangan are 30 fu 4 han and 60 fu 3 han, it is better to explicitly list them. (120 fu always includes sankantsu, so it becomes mangan.)
| :ivar kiriage: round up to mangan when han/fu are at the boundary (e.g. 4 han 30 fu) | ||
| :vartype kiriage: bool | ||
| :ivar fu_for_open_pinfu: award 2 fu for open hands with no other fu sources; | ||
| when False, 1 han 20 fu hands become possible |
Collaborator
There was a problem hiding this comment.
It would be a good idea to also correct the relevant part of the English Wiki.
A separate PR is fine.
| :vartype fu_for_pinfu_tsumo: bool | ||
| :ivar renhou_as_yakuman: treat renhou as yakuman instead of mangan | ||
| :vartype renhou_as_yakuman: bool | ||
| :ivar has_daisharin: enable daisharin (seven consecutive pairs in one suit) as yakuman; |
Collaborator
There was a problem hiding this comment.
I think it would be better to explicitly write 22334455667788 in pin
| :ivar has_daisharin: enable daisharin (seven consecutive pairs in one suit) as yakuman; | ||
| automatically set to True when ``has_daisharin_other_suits`` is True | ||
| :vartype has_daisharin: bool | ||
| :ivar has_daisharin_other_suits: allow daisharin in pin and sou suits (not only man) |
Collaborator
There was a problem hiding this comment.
The correct explanation is "not only pin", so please correct it.
| :vartype has_daisharin: bool | ||
| :ivar has_daisharin_other_suits: allow daisharin in pin and sou suits (not only man) | ||
| :vartype has_daisharin_other_suits: bool | ||
| :ivar has_daichisei: enable daichisei (seven pairs of honor tiles) as yakuman |
Collaborator
There was a problem hiding this comment.
I think it would be better to clarify that it is all honors (tsuuiisou).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#121
add hand config doc and fix few inconsistencies in already added doc files