docs: update DirectHit algorithm section in documentation#1158
Closed
Windsland52 wants to merge 3 commits intomainfrom
Closed
docs: update DirectHit algorithm section in documentation#1158Windsland52 wants to merge 3 commits intomainfrom
Windsland52 wants to merge 3 commits intomainfrom
Conversation
Added additional fields for the DirectHit algorithm in the documentation.
Contributor
There was a problem hiding this comment.
Hey - 我已经审查了你的更改,看起来非常棒!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进之后的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Added additional fields required for the DirectHit algorithm.
MistEO
reviewed
Feb 28, 2026
| 该算法属性需额外部分字段: | ||
|
|
||
| - `roi`: *array<int, 4>* | *string* | ||
| 同 `TemplateMatch`.`roi` 。 |
Member
There was a problem hiding this comment.
DirectHit 在前面的,同后面的 TemplateMatch 总感觉哪里不对劲)
另外再好说一下这玩意在 DirectHit 里的实际效果?
Member
Author
There was a problem hiding this comment.
难道写在directhit里,别的同directhit吗,感觉怪怪的
效果的话,跟别的好像也没啥区别吧,就是直接把roi作为box返回
Contributor
There was a problem hiding this comment.
因为这是个现象而非设计(大概
所以很难说有没有用(
Member
Author
There was a problem hiding this comment.
要是 and or 改之前的话还是有点用的
Member
Author
There was a problem hiding this comment.
directhit用roi的感觉大部分都是没搞懂roi box 和target区别的
Member
Author
|
先这样吧,roi,box,target区分另开一个pr |
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体性的反馈:
- 对于类似
Same asDirectHit.roi这样的交叉引用行内代码格式有点别扭;可以考虑改成 `Same as DirectHit.roi.` 或 `Same as \\`DirectHit\\`.\\`roi\\,这样在 Markdown 渲染时会更清晰。 - 在
roi的说明中使用表情符号标记**💡 v5.6**可能与文档其余部分的风格不太一致;为保持一致性,可以考虑改成纯文本提示,例如Note (v5.6): ...。
给 AI Agent 的提示词
Please address the comments from this code review:
## Overall Comments
- The inline code formatting for cross-references like `Same as `DirectHit`.`roi`` is a bit awkward; consider using `Same as DirectHit.roi.` or `Same as \\`DirectHit\\`.\\`roi\\`` for clearer markdown rendering.
- The use of the emoji marker `**💡 v5.6**` in the `roi` description may be inconsistent with the rest of the docs style; consider switching to a plain text note like `Note (v5.6): ...` for consistency.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进之后的 Review。
Original comment in English
Hey - I've left some high level feedback:
- The inline code formatting for cross-references like
Same asDirectHit.roiis a bit awkward; consider using `Same as DirectHit.roi.` or `Same as \\`DirectHit\\`.\\`roi\\for clearer markdown rendering. - The use of the emoji marker
**💡 v5.6**in theroidescription may be inconsistent with the rest of the docs style; consider switching to a plain text note likeNote (v5.6): ...for consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline code formatting for cross-references like `Same as `DirectHit`.`roi`` is a bit awkward; consider using `Same as DirectHit.roi.` or `Same as \\`DirectHit\\`.\\`roi\\`` for clearer markdown rendering.
- The use of the emoji marker `**💡 v5.6**` in the `roi` description may be inconsistent with the rest of the docs style; consider switching to a plain text note like `Note (v5.6): ...` for consistency.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
|
草了,修改直接被新pr给合了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional fields for the DirectHit algorithm in the documentation.
由 Sourcery 提供的摘要
文档:
Original summary in English
Summary by Sourcery
Documentation:
roi和roi_offset配置字段,并在其他算法章节中引用这些字段以避免重复。Original summary in English
Summary by Sourcery
Documentation:
roiandroi_offsetconfiguration fields for the DirectHit algorithm in the English pipeline protocol documentation and reference these fields from other algorithm sections to avoid duplication.