Skip to content

DungeonMission Value1 & Value2 type fix #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AngeloTadeucci merged 1 commit into from
May 9, 2026
+3 −3
Merged

DungeonMission Value1 & Value2 type fix #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Maple2.File.Parser/Maple2.File.Parser.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<PackageTags>MapleStory2, File, Parser, m2d, xml</PackageTags>
<!-- Use following lines to write the generated files to disk. -->
<EmitCompilerGeneratedFiles Condition=" '$(Configuration)' == 'Debug' ">true</EmitCompilerGeneratedFiles>
<PackageVersion>2.4.8</PackageVersion>
<PackageVersion>2.4.9</PackageVersion>
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use a breaking-version bump for this release.

Line 16 sets a patch release, but this PR changes public member types in DungeonMission, which is a breaking contract change for consumers. Please bump to a major version before publishing.

Suggested change 
-        <PackageVersion>2.4.9</PackageVersion>
+        <PackageVersion>3.0.0</PackageVersion>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<PackageVersion>2.4.9</PackageVersion>
<PackageVersion>3.0.0</PackageVersion>
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Maple2.File.Parser/Maple2.File.Parser.csproj` at line 16, The project file
currently sets <PackageVersion> to 2.4.9 which is a patch bump even though the
PR changes public member types on DungeonMission (a breaking change); update the
<PackageVersion> element value from 2.4.9 to a major-breaking version (e.g.
3.0.0) so the package is published with a major version bump reflecting the API
break.

<TargetFramework>net8.0</TargetFramework>
<PackageReadmeFile>README.md</PackageReadmeFile>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down
4 changes: 2 additions & 2 deletions Maple2.File.Parser/Xml/Table/DungeonMission.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ public partial class DungeonMissionRoot {
public partial class DungeonMission : IFeatureLocale {
[XmlAttribute] public int id;
[XmlAttribute] public string type = string.Empty;
[M2dArray] public float[] value1 = Array.Empty<float>();
[XmlAttribute] public int value2 = 0;
[XmlAttribute] public string value1 = string.Empty;
[XmlAttribute] public string value2 = string.Empty;
[XmlAttribute] public int maxScore;
[XmlAttribute] public int applyCount;
[XmlAttribute] public bool isPenaltyType;
Expand Down
Loading