feat: add GitHub deployment environments for containers, docs, and homebrew#1424
Merged
Conversation
Contributor
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Claude Code ReviewHead SHA: d5030e5 Files changed:
FindingsMissing artifact upload in
|
github.repository_owner returns 'MFlowCode' (mixed case), but GHCR
requires all-lowercase repository names, causing tag validation errors.
Compute GH_REGISTRY=ghcr.io/${OWNER,,}/mfc in a shell step so the
lowercasing happens at runtime rather than at expression-eval time.
sbryngelson
added a commit
to sbryngelson/MFC
that referenced
this pull request
May 11, 2026
…ent environment
sbryngelson
added a commit
to sbryngelson/MFC
that referenced
this pull request
May 11, 2026
…ent environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment:blocks to the three workflows that actually deploy artifacts, so they show up in the Deployments sidebar on the repo pagedocs.ymlinto abuildjob (runs on all events) and apublishjob (runs only on master schedule/dispatch, has the environment) so deployment events only fire on real publishesEnvironments added
containersdocker.ymlmanifests jobdocsdocs.ymlpublish jobhomebrewdeploy-tap.yml+homebrew-release.ymlWhat won't show up (and why)