Fix add_transformations broken state after invalid input#5265
Fix add_transformations broken state after invalid input#5265harshitgajjela-droid wants to merge 2 commits intoMDAnalysis:developfrom
Conversation
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5265 +/- ##
===========================================
- Coverage 93.83% 86.15% -7.69%
===========================================
Files 180 180
Lines 22473 22476 +3
Branches 3189 3191 +2
===========================================
- Hits 21088 19364 -1724
- Misses 923 2658 +1735
+ Partials 462 454 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
102a08c to
b21338c
Compare
Fixes #2558
Changes made in this Pull Request:
add_transformationsto raiseTypeErrorif any transformation is not callable, preventing broken trajectory statetest_add_transformations_rejects_non_callableintestsuite/MDAnalysisTests/coordinates/base.pyLLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
package/CHANGELOGfile updated?package/AUTHORS?I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5265.org.readthedocs.build/en/5265/