[true-async] drop HTTP/3 listener#744
Draft
EdmondDantes wants to merge 2 commits into
Draft
Conversation
…limited-conn The v0.6.3 benchmark run skipped the short-lived (limited-conn) profile with `[warn] true-async-server did not come up for limited-conn` for both 512c and 4096c — the server container never passed the health probe, so no result was recorded and the leaderboard shows short-lived as "not participating". entry.php registered an HTTP/3 QUIC listener on UDP 8443 whenever H3_DISABLE != "1" (the benchmark runner never sets it). meta.json subscribes to no h3 profile, so that listener serves nothing — but its UDP bind is an extra startup step that races with the previous container's teardown on back-to-back profile runs, intermittently making HttpServer::start() fail before the probe succeeds. baseline and pipelined (earlier in the run) came up; limited-conn (3rd) lost twice. Remove the H3 listener and the dead H3_PORT / H3_DISABLE env plumbing. The arena image never benchmarks HTTP/3.
EdmondDantes
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
Contributor
Author
|
/benchmark -f true-async-server --save |
Contributor
|
👋 |
EdmondDantes
changed the title
Contributor
Benchmark ResultsFramework:
Full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.6.3 benchmark run (after #742) skipped
limited-connfor both 512c and 4096c:No result was recorded, so the leaderboard shows short-lived as not participating.
Cause
entry.phpregistered an HTTP/3 QUIC listener on UDP 8443.meta.jsonsubscribes to no h3 profile, so that listener serves nothing — but its UDP bind is an extra startup step that races with the previous container's teardown on back-to-back profile runs, intermittently makingHttpServer::start()fail before the health probe succeeds.baselineandpipelined(earlier in the run) came up;limited-conn(3rd) lost the race twice.Fix
Drop the H3 listener and the dead
H3_PORT/H3_DISABLEenv plumbing. The arena image never benchmarks HTTP/3 — removing the listener eliminates the failure vector and trims startup work.One-file change; branched off current
main(post-#742).