Remove literals from IOR files#13
Open
matteomarone wants to merge 1 commit intoLudwigFriedmann:masterfrom
Open
Remove literals from IOR files#13matteomarone wants to merge 1 commit intoLudwigFriedmann:masterfrom
matteomarone wants to merge 1 commit intoLudwigFriedmann:masterfrom
Conversation
Owner
|
Relates to #3, I'll have to do adopt parsing in the pathtracer implementation, schemas and the documentation first |
Owner
|
This PR implements changes in the asset info, as well. I'd like to have this topic separate, since it also implies changes in parsing, schema and docs. |
Owner
|
Hi @matteomarone, I applied all changes relevant for the "removal of literals" (implementation, doc, schemas) on master. Can you adjust this PR in a way that it comprises the proposed changes in asset info, only? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In IOR files, literals were used as keys. Now the proper fields ("temperature") are assigned.