Fix: Reduce render thread idle delay for smoother UI (~60fps) #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main render loop had a 100ms SDL_Delay in the idle path, limiting the UI to ~10fps when the dirty flag wasn't set. Changed to 16ms (~60fps) to match standard frame budget. Two identical 100ms delays at lines 1868 and 1908 were already commented out by the team. The nearby else branch (line 3322) already uses SDL_Delay(17), confirming 16-17ms is the intended frame timing. WHY: The game switcher and quick menu felt sluggish and unresponsive. This single-line fix makes all UI navigation dramatically smoother with zero risk — 16ms is the standard 60fps frame budget used across the rest of the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SDL_Delay(100)toSDL_Delay(16)in the main render loop idle path (nextui.c:3307)Context
The render thread's idle branch had a 100ms delay, making the game switcher and quick menu feel sluggish. Two identical
SDL_Delay(100)calls at lines 1868 and 1908 were already commented out by the team, and the nearby else branch (line 3322) already usesSDL_Delay(17)— confirming 16-17ms is the intended frame timing.This aligns with the existing inline comment: "why are we running long delays on the render thread, wtf?"
Testing