refactor(token-interface): migrate tests from vitest to cucumber-js#2365
Open
ananas-block wants to merge 24 commits intoswen/single-ixfrom
Open
refactor(token-interface): migrate tests from vitest to cucumber-js#2365ananas-block wants to merge 24 commits intoswen/single-ixfrom
ananas-block wants to merge 24 commits intoswen/single-ixfrom
Conversation
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (5)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ananas-block
force-pushed
the
jorrit/refactor-tests-to-cucumber
branch
from
eeda9e7 to
2d724be
Compare
Replace all vitest test files with Gherkin feature files and
cucumber-js TypeScript step definitions. 11 unit scenarios and
11 E2E scenarios preserve full test coverage.
- Add @cucumber/cucumber and tsx, remove vitest and eslint-plugin-vitest
- Create cucumber.js config with unit/e2e/default profiles
- Create World class and hooks infrastructure
- Write 8 feature files and 9 step definition files
- Delete all *.test.ts files and vitest.config.ts
- Update eslint, tsconfig, and package.json scripts
- Fix CI branch filter ("*" -> "**") for slash-containing base branches
- Update pnpm-lock.yaml
ananas-block
force-pushed
the
jorrit/refactor-tests-to-cucumber
branch
from
76df4cd to
ff7552d
Compare
SwenSchaeferjohann
force-pushed
the
swen/single-ix
branch
from
963ac04 to
a7336af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js/token-interface/tests from Vitest to Cucumber-js with Gherkin feature filesChanges
cucumber.jsconfig with unit/e2e/default profilestests/support/world.ts(custom World class) andtests/support/hooks.ts.featurefiles underfeatures/unit/andfeatures/e2e/.steps.tsfiles undertests/step-definitions/.test.tsfiles andvitest.config.tspackage.json(deps + scripts),tsconfig.test.json,eslint.config.cjsTest plan
pnpm --filter @lightprotocol/token-interface test:unit:all(11 scenarios, 42 steps)pnpm --filter @lightprotocol/token-interface test:e2e:all(requires validator)js/token-interface/