Fix "null" and unpopulated fields#58
Open
Lightning11wins wants to merge 4 commits into
Open
Conversation
… import app. Populate address line 3. Populate title. Populate suffix.
Lightning11wins
added
bug
size: trivial
nboard
previously requested changes
Apr 28, 2026
Fix missing set_phone_area_country parameter. Rename set_phone_country_cn to set_phone_area_country_guess_cn to improve clarity. Fix set_phone_area_country_guess_cn triggering even if a correct phone area country code was explicitly specified.
Contributor
|
Looks good to me! |
Author
|
Great, are you allowed to approve the PR so that I can merge it or do we need to wait for Greg to review and approve it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix blank fields being populated with the word
nulland non-blank fields not being populated when adding new partners during a gift import from the gift import app.Records in the new partner app before this change:
Records in the new partner app after this change:
