Add Pipeline Tooltips Read From Pipeline Headers#1570
Open
mattdawkins wants to merge 1 commit intomainfrom
Open
Add Pipeline Tooltips Read From Pipeline Headers#1570mattdawkins wants to merge 1 commit intomainfrom
mattdawkins wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
Within the latest published or even the master branch of the VIAME Repo there are no pipelines/configs that contain |
mattdawkins
force-pushed
the
dev/add-pipeline-tooltips
branch
from
1b29867 to
f543c28
Compare
Main already extracts the metadata; this just wires it through to the dropdown UIs that weren't surfacing it. - Solid dark background on .pipeline-description-tooltip in RunPipelineMenu so the text is readable. - MultiPipeline (desktop): tooltip on each pipeline showing metadata.description. - MultiTrainingMenu (desktop) + web-girder RunTrainingMenu: same treatment for TrainingConfig.description; switch to item-text/ item-value="name" and render item.name in the selection slot.
mattdawkins
force-pushed
the
dev/add-pipeline-tooltips
branch
from
f543c28 to
14e8666
Compare
Collaborator
|
is this superseded by #1624 from @Louis-Pagnier-KW? If so this PR should probably be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surface the pipeline / training-config description (read from each `.pipe` / `.conf` header) as a hover tooltip in the dropdown menus that don't already show it.
The header-extraction pipeline (`extract_pipe_metadata` server-side, `extractPipeMetadata` client-side) is already on main; this PR is just the UI wire-up that was missing.
Changes vs main
This rebase drops the original branch's `extract_pipe_description` / `PipelineDescription.description` plumbing because main now provides the same data through the richer `PipeMetadata` / `TrainingConfig.description` types.