Skip to content

Stop line chaining when snapping to other segment#11655

Open
andrewvarga wants to merge 12 commits into
mainfrom
andrewvarga/adhoc/stop-line-chaining-when-snapping-to-other-segment
Open

Stop line chaining when snapping to other segment#11655
andrewvarga wants to merge 12 commits into
mainfrom
andrewvarga/adhoc/stop-line-chaining-when-snapping-to-other-segment

Conversation

@andrewvarga
Copy link
Copy Markdown
Contributor

Very small UX improvement when using the Line tool.

Previously: when any new constraint is created during line placement the line tool will stop chaining to the previous line. Even if you snapped vertically/horizontally to the ORIGIN the chaining stopped.

Now: only stop chaining if there is a new Coincident constraint added, which does not involve the ORIGIN. Snapping to the ORIGIN keeps the lines going:

Screenshare.-.2026-05-14.5_23_21.PM.mp4

@andrewvarga andrewvarga requested a review from a team as a code owner May 14, 2026 15:24
@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment May 21, 2026 11:06pm

Request Review

@max-mrgrsk
Copy link
Copy Markdown
Contributor

hey, why do we ever want to stop chaining?

polyline.mp4

@andrewvarga
Copy link
Copy Markdown
Contributor Author

hey, why do we ever want to stop chaining?

polyline.mp4

That's a good example. We added this as a convenience to stop chaining when you click on the first point of the first line in your polygon (you're "closing" it). However it's true that when you snap to lines it shouldn't stop chaining.
I updated that so now the chaining only stops if you snap to another point, just checked and onshape works like this too:

Screenshare.-.2026-05-15.12_00_16.AM.mp4

But if you think it's not necessary I can disable the entire thing, so chaining never stops.

@andrewvarga
Copy link
Copy Markdown
Contributor Author

hey, why do we ever want to stop chaining?
polyline.mp4

That's a good example. We added this as a convenience to stop chaining when you click on the first point of the first line in your polygon (you're "closing" it). However it's true that when you snap to lines it shouldn't stop chaining. I updated that so now the chaining only stops if you snap to another point, just checked and onshape works like this too:

Screenshare.-.2026-05-15.12_00_16.AM.mp4
But if you think it's not necessary I can disable the entire thing, so chaining never stops.

@max-mrgrsk let me know what you think and I'll update accordingly!

@max-mrgrsk
Copy link
Copy Markdown
Contributor

@andrewvarga I think it's perfect now! tysm!

@andrewvarga
Copy link
Copy Markdown
Contributor Author

andrewvarga commented May 21, 2026

@andrewvarga I think it's perfect now! tysm!

@max-mrgrsk cool, I'll just need an approve here from anyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants