Skip to content

Fix sketch on the face of a translated extrude#11611

Draft
pierremtb wants to merge 12 commits into
mainfrom
pierremtb/issue11598-cant-sketch-on-the-face-of-a-translated-extrude
Draft

Fix sketch on the face of a translated extrude#11611
pierremtb wants to merge 12 commits into
mainfrom
pierremtb/issue11598-cant-sketch-on-the-face-of-a-translated-extrude

Conversation

@pierremtb
Copy link
Copy Markdown
Contributor

@pierremtb pierremtb commented May 12, 2026 •
edited
Loading

Fixes #11598. Codex written.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment May 22, 2026 7:47pm

Request Review

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 119 untouched benchmarks
⏩ 150 skipped benchmarks1

Comparing pierremtb/issue11598-cant-sketch-on-the-face-of-a-translated-extrude (9fb12ff) with main (c1f9b64)2

Open in CodSpeed

Footnotes

  1. 150 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (c7f3d5e) during the generation of this report, so c1f9b64 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@pierremtb pierremtb changed the title Codex: Fix sketch on the face of a translated extrude Fix sketch on the face of a translated extrude May 13, 2026
@pierremtb pierremtb marked this pull request as ready for review May 13, 2026 13:16
@pierremtb pierremtb requested a review from a team as a code owner May 13, 2026 13:16
jtran
jtran reviewed May 13, 2026
View reviewed changes
Comment thread rust/kcl-lib/src/frontend.rs Outdated
Some(SourceRef::Simple {
range: *range,
node_path: Some(ast::NodePath {
steps: node_path.steps[..pipe_step_index].to_vec(),
Copy link
Copy Markdown
Contributor

@jtran jtran May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. Steps is a Vec path from the ast root.

Copy link
Copy Markdown
Contributor Author

@pierremtb pierremtb May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I'll look into it!

@pierremtb pierremtb force-pushed the pierremtb/issue11598-cant-sketch-on-the-face-of-a-translated-extrude branch from 7079141 to 39827aa Compare May 14, 2026 19:40
@pierremtb
Copy link
Copy Markdown
Contributor Author

pierremtb commented May 14, 2026

Ugh sorry didn't mean to force push

@pierremtb pierremtb marked this pull request as draft May 14, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtran jtran jtran left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't sketch on the face of a translated extrude

2 participants

@pierremtb @jtran