cleanup / bugfix: replace hand-rolled Kafka wire protocol with franz-go's kmsg#132
Merged
klaudworks merged 1 commit intoKafScale:mainfrom Mar 3, 2026
Merged
Conversation
klaudworks
force-pushed
the
kmsg-wire-protocol
branch
from
1a06c1e to
40d93f7
Compare
klaudworks
changed the title
novatechflow
approved these changes
Mar 3, 2026
Collaborator
novatechflow
left a comment
novatechflow
left a comment
There was a problem hiding this comment.
Thank you @klaudworks - that was on my ToDo list!
kamir
added a commit
to kamir/kafscale
that referenced
this pull request
Mar 5, 2026
Align all LFS modules and test files with the kmsg type aliases introduced in upstream PR KafScale#132. Updates field names (Topic, Partition, Leader, Replicas, ISR, TimeoutMillis, TransactionID, Generation) and replaces removed protocol helpers in encoding/request tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces our custom Kafka wire protocol encoding/decoding with
kmsgtypes from franz-go. Net deletion of ~6,900 lines.We maintained a full set of custom request/response structs and hand-written binary encoders/decoders for every Kafka API we support. This was effectively reimplementing what
kmsgalready does.This also fixes compatibility issues with some Kafka clients that failed on unsupported protocol versions due to our incomplete version handling.