fix: use async bcrypt to avoid blocking the event loop#147
fix: use async bcrypt to avoid blocking the event loop#147rotarymars wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing: the async bcrypt change is already included in PR #146 (login route) and the signup route change will be addressed separately. |
Replace malformed dummy hash (48 chars) with a properly generated bcrypt hash (60 chars) so timing-attack prevention works correctly. Also switch signup route from bcrypt.hashSync to async bcrypt.hash to avoid blocking the event loop (subsumes PR #147). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Description
Added async for better performance.
Type of Change
Changes Made
Testing
npm run devnpm run build)npm run lint)Screenshots (if applicable)
Checklist
Related Issues