Fix: WakeLock finalized while still held#101
Open
JulianAssmann wants to merge 1 commit intomasterfrom
Open
Conversation
Release any existing WakeLock/WifiLock before re-acquiring in startService() to prevent orphaned locks being GC'd while still held. Also handle null intents in onStartCommand (OS sticky restart) by calling startService() so locks are properly re-acquired after a system kill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35
Summary
startService(), any existing held lock is now released first. This prevents orphaned lock objects from being GC'd while still held, which caused theWakeLock finalized while still heldlogcat error.onStartCommandnow handlesnullintents (delivered by Android onSTART_STICKYservice restarts after a system kill) by callingstartService(), ensuring locks are properly re-acquired after the OS kills and restarts the service.Test plan
enableBackgroundExecution()twice without disabling — verify noWakeLock finalized while still heldin logcatenableBackgroundExecution()thendisableBackgroundExecution()— verify no error appears a few seconds lateradb shell am kill <package>while service is running — verify service restarts and continues functioning