avoid Core.Box in the package
#3520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used JuliaLang/julia#60478 to find all the `Core.Box` instances in the package and then fix them.
bkamins
reviewed
Dec 30, 2025
| extrude = false | ||
|
|
||
| firstrow = first | ||
| wrapped_first = nothing |
Member
There was a problem hiding this comment.
is this assignment needed? (we make sure not to access wrapped_first if extrude is false)
bkamins
reviewed
Dec 30, 2025
| wrapped_first = nothing | ||
| lgd = length(gd) | ||
| if first isa AbstractDataFrame | ||
| if firstrow isa AbstractDataFrame |
Member
There was a problem hiding this comment.
should eltys assignment be outside of if (as you did above in src/abstractdataframe/iteration.jl change)
Member
|
Thank you for working on this. I left two small comments. |
nalimilan
reviewed
Dec 30, 2025
Member
nalimilan
left a comment
nalimilan
left a comment
There was a problem hiding this comment.
Thanks. It's too bad we need this kind of trick but...
src/dataframe/dataframe.jl
Outdated
| end | ||
| len == -1 && (len = 1) # we got no vectors so make one row of scalars | ||
|
|
||
| len_val = len |
Member
There was a problem hiding this comment.
Call this len_local like in other places to make it easier to guess why we do this?
Member
Author
|
Updated |
nalimilan
approved these changes
Jan 5, 2026
bkamins
approved these changes
Jan 5, 2026
Member
|
Thank you for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used JuliaLang/julia#60478 to find all the
Core.Boxinstances in the package and then fix them. A variable that gets boxed like this will lose any type information, which can cascade into bad performance and vulnerability to invalidations.The rules are basically that you cannot use a variable in a closure if that variable has been assigned to more than once. Also, using
Base.@lockinstead oflock() doavoids a closure. And if you have a closure that calls itself recursively, it is better to make that a normal function; otherwise, the closure itself will get boxed. Etc...