Revert to cpu if cuda is not available (simpler version)#11
Open
JasonGross wants to merge 1 commit intoJoshEngels:mainfrom
Open
Revert to cpu if cuda is not available (simpler version)#11JasonGross wants to merge 1 commit intoJoshEngels:mainfrom
JasonGross wants to merge 1 commit intoJoshEngels:mainfrom
Conversation
Also allow passing `--device cpu`, `--device mps`, etc to `circle_probe_interventions.py`, and remove the logic for special handling of numbers *n* as `cuda:n` to simplify logic.
JasonGross
changed the title
Tauheed-Elahee
added a commit
to Tauheed-Elahee/MultiDimensionalFeatures
that referenced
this pull request
Mar 12, 2026
JoshEngels#11 device handling + add dtype
Tauheed-Elahee
added a commit
to Tauheed-Elahee/MultiDimensionalFeatures
that referenced
this pull request
Mar 13, 2026
JoshEngels#11 device handling + add dtype
Tauheed-Elahee
added a commit
to Tauheed-Elahee/MultiDimensionalFeatures
that referenced
this pull request
Mar 13, 2026
Most machines index GPUs from 0. The previous default of cuda:4 assumed a specific multi-GPU server setup and would fail on machines with fewer than 5 GPUs. Depends on PR JoshEngels#11 (CPU fallback).
Tauheed-Elahee
added a commit
to Tauheed-Elahee/MultiDimensionalFeatures
that referenced
this pull request
Mar 13, 2026
Most machines index GPUs from 0. The previous default of cuda:4 assumed a specific multi-GPU server setup and would fail on machines with fewer than 5 GPUs. Depends on PR JoshEngels#11 (CPU fallback).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also allow passing
--device cpu,--device mps, etc tocircle_probe_interventions.py, and remove the logic for special handling of numbers n ascuda:nto simplify logic.Simpler alternative to #7
Closes #7