Closed
Conversation
This was referenced Aug 9, 2019
Author
|
Sorry I underestimated the effort to apply these changes, there is an issue that I do not understand why it is happening and how I should fix it. I am going to close this PR and hopefully the original author will do a better job :-) |
|
thanks for trying :) |
Member
|
I think it would be wiser to reuse an existing Java parser, we could pick the one used by the Eclipse Compiler, the Javac parser in OpenJDK, or JavaParser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Java 7 default method for interface and Java 8 lambdas and method references with tests, plus a fix and a test previously found by Cobertura.
These changes are almost the same as codehaus#3 (cherry-picked commits with minor adjustments as this repo is ahead of codehaus/javancss:master).