fix(codeql-resolver): add .md extension to skill paths#59
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 327bfed in 7 seconds. Click for details.
- Reviewed
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_XcOmRzexwv2OV8ph
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request fixes a path resolution issue in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a path resolution error by adding the .md extension to skill paths in codeql-resolver/.claude-plugin/plugin.json. However, this change introduces a schema validation issue, as the pattern for skills in schemas/plugin.schema.json does not currently allow for the .md extension. I've left a comment detailing the issue and recommending an update to the schema file to ensure consistency and validity.
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix path resolution errors in the codeql-resolver plugin by adding .md extensions to skill paths in plugin.json. The actual skill files (codeql-permission-classification.md and github-workflow-security-patterns.md) exist as direct .md files, and Claude Code's runtime requires the .md extension in the plugin manifest to resolve them correctly. However, this change conflicts with the JSON schema validation used in CI.
Changes:
- Add
.mdextensions to two skill paths in codeql-resolver plugin.json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Skill paths in plugin.json must reference directories containing SKILL.md, not flat .md files. The two skills were stored as flat .md files which Claude Code cannot load via the directory-based skill loading mechanism. - codeql-permission-classification.md -> codeql-permission-classification/SKILL.md - github-workflow-security-patterns.md -> github-workflow-security-patterns/SKILL.md plugin.json paths remain unchanged (no .md extension) - this is correct per schema. (claude)
327bfed to
853bba9
Compare
Summary
.mdextension to skill paths incodeql-resolver/.claude-plugin/plugin.json./skills/codeql-permission-classificationand./skills/github-workflow-security-patternswere missing the.mdextension, causing path resolution errors when Claude Code loaded the pluginTest plan
nix flake update jacobpevans-cc-pluginsin nix-ai picks up the fix🤖 Generated with Claude Code
Important
Add missing
.mdextensions to skill paths inplugin.jsonto fix path resolution errors..mdextension to skill paths incodeql-resolver/.claude-plugin/plugin.json../skills/codeql-permission-classificationand./skills/github-workflow-security-patternsto./skills/codeql-permission-classification.mdand./skills/github-workflow-security-patterns.md.nix flake update jacobpevans-cc-pluginsin nix-ai picks up the fix.codeql-resolverwithout skill path errors.This description was created by
for 327bfed. You can customize this summary. It will automatically update as commits are pushed.