fix(resolve-pr-threads): rewrite negation rules as affirmative clarity#58
Conversation
Replace "DO NOT" prohibition lists with affirmative rules that tell agents exactly what TO do, reducing the risk of latching onto the wrong patterns. Key changes: - SKILL.md: Replace ## DO NOT section with ## Rules using bold affirmative statements; correct Step 3b to use REST API instead of gh pr comment - rest-api-patterns.md: Replace "Fallback: Top-Level PR Comment" with "When REST Reply Fails" diagnosis table; fix troubleshooting row to recommend diagnosis over fallback - graphql-queries.md: Add "When a Mutation Fails" diagnosis flow after Mutation Reference Table - plugin.json: Bump version 1.0.0 → 1.1.0 to invalidate stale cache (claude)
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5507885 in 7 seconds. Click for details.
- Reviewed
103lines of code in4files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_ARXwA579yZ53Kogy
You can customize 
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the clarity and robustness of the PR thread resolution process by reframing instructions from prohibitions to positive rules, providing detailed error diagnosis flows for both REST and GraphQL API interactions, and correcting specific command usage. The changes aim to prevent common pitfalls, improve the reliability of automated responses, and ensure that all replies are properly threaded within pull request conversations. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the clarity and correctness of the agent skills documentation by replacing prohibitive rules with affirmative guidance and refining error-handling procedures. The changes are well-aligned with the goal of preventing incorrect agent behavior, such as posting unresolvable top-level comments. I have a couple of suggestions to further enhance the clarity of the documentation and prevent potential confusion for the agent.
github-workflows/skills/resolve-pr-threads/rest-api-patterns.md
Outdated
Show resolved
Hide resolved
…permission error guidance - SKILL.md: Clarify that top-level comments are prohibited only for thread replies, not for non-threaded feedback responses - rest-api-patterns.md: Remove 're-fetch thread IDs' from Resource not accessible fix; re-fetching helps with stale IDs, not permissions (claude)
There was a problem hiding this comment.
Pull request overview
Updates the resolve-pr-threads skill documentation to replace negative prohibitions and fallback behaviors with affirmative rules and error-diagnosis guidance, aiming to keep agents replying/resolving within review threads and avoiding unresolvable top-level comment workflows.
Changes:
- Replaces the “Fallback: Top-Level PR Comment” guidance with a diagnosis table for REST reply failures.
- Adds mutation-failure diagnosis guidance to the GraphQL query reference.
- Rewrites
SKILL.mdprohibitions into an affirmative “Rules” section and updates the Step 3b sub-agent prompt to use the Issues comments REST endpoint.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| github-workflows/skills/resolve-pr-threads/rest-api-patterns.md | Removes fallback-to-top-level-comment guidance and replaces it with error-specific REST reply diagnostics. |
| github-workflows/skills/resolve-pr-threads/graphql-queries.md | Adds a “When a Mutation Fails” diagnostic flow for GraphQL replies. |
| github-workflows/skills/resolve-pr-threads/SKILL.md | Replaces “DO NOT” list with affirmative rules; updates the comment-group sub-agent reply command. |
| github-workflows/.claude-plugin/plugin.json | Bumps plugin version from 1.0.0 to 1.1.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…diagnosis accuracy - SKILL.md: Expand top-level comment prohibition to explicitly name the Issues comments API as also off-limits for thread replies, while clarifying top-level comments are fine for general PR feedback - SKILL.md: Rewrite Step 3b to distinguish non-thread comments from thread replies, preventing Issues API misuse as a thread reply fallback - graphql-queries.md: Correct 'doesn't accept argument' diagnosis — this error means wrong argument name/input shape, not wrong mutation name; add a Note for 'Cannot query field' errors which do indicate wrong name (claude)
Summary
## DO NOTprohibition list inSKILL.mdwith affirmative## Rulessection — tells agents what TO do with correct mutations/commands front and centerrest-api-patterns.mdwith "When REST Reply Fails" diagnosis table — eliminates the fallback pattern that caused agents to post unresolvable top-level commentsgraphql-queries.mdwith error-specific remediation stepsgh api .../issues/{number}/comments) instead ofgh pr comment1.0.0→1.1.0to bust stale cachesTest Plan
markdownlint-cli2— 0 errors across all 3 modified skill filescspell— 0 issues across all 3 modified skill filestest_graphql_guidance.py— 8/8 tests passaddPullRequestReviewCommentappears only in reference/warning rows🤖 Generated with Claude Code
Important
Rewrite negation rules as affirmative in documentation, fix command usage, and bump version to 1.1.0.
## DO NOTsection inSKILL.mdwith## Rulesfor affirmative guidance.rest-api-patterns.mdwith "When REST Reply Fails" diagnosis table.graphql-queries.md.gh api .../issues/{number}/commentsinstead ofgh pr commentinSKILL.md.1.0.0to1.1.0inplugin.json.This description was created by
for 5507885. You can customize this summary. It will automatically update as commits are pushed.