Skip to content

[chore]: simplify staging comment lifecycle and improve deploy status reliability#420

Merged
rorychatt merged 1 commit intomainfrom
feat/improve-logic-update-comment-for-pr-staging
Apr 2, 2026
Merged

[chore]: simplify staging comment lifecycle and improve deploy status reliability#420
rorychatt merged 1 commit intomainfrom
feat/improve-logic-update-comment-for-pr-staging

Conversation

@ArtemLazarchuk
Copy link
Copy Markdown
Collaborator

Summary

  • Comment lifecycle simplifiedTryPostOrUpdateStagingCommentAsync now always
    deletes all prior marker comments and posts a fresh one. Removed forceNewComment
    parameter (was true in every non-trivial call anyway). Added retry loop in
    DeleteAllMarkerCommentsAsync so stale comments are reliably cleaned up.

  • Immediate "queued" notifications — After enqueuing a deploy (new, redeploy,
    re-sync, webhook trigger) the PR comment is updated right away via
    TryNotifyDeployQueuedAsync, so contributors see progress instead of a stale
    "Deleted" or blank comment while the background worker starts.

  • Deploy status resolution — Events and listing APIs are now polled in parallel
    and merged via MergeEventAndListingStatus (failure wins, then deployed, else
    pending). Removed the 5-minute "listing fallback" timer; listing is checked every
    tick, eliminating the lag window.

  • Orphan service fixDeployBranchAsync now tears down existing PR services
    before creating new ones, preventing leftover Sliplane services when a
    synchronize event triggers a fallback deploy alongside existing services.

  • 404 on comment delete treated as successDeleteIssueCommentAsync no longer
    returns false when the comment is already gone, removing spurious warnings.

…eNewComment parameter from TryPostOrUpdateStagingCommentAsync and update related calls. Introduce new methods for notifying deploy status updates, enhancing clarity and maintainability. Update GitHubApiClient to handle NotFound status on comment deletion. Improve deployment status resolution in background service by merging event and listing statuses.
@ArtemLazarchuk ArtemLazarchuk requested a review from rorychatt April 2, 2026 19:35
@ArtemLazarchuk ArtemLazarchuk self-assigned this Apr 2, 2026
@rorychatt rorychatt merged commit b8c7d1e into main Apr 2, 2026
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants